committer filter by committer.
@path/to/ filter by path in repository.
committer@path/to/ filter by committer AND path in repository.
abdef0123 filter by commit's SHA hash.
rNNN filter by SVN revision.
rNNN-rMMM filter by SVN revisions range (inclusive).
Multiple filters can be specified separated by spaces or comas in which case they'll be combined using OR operator.
|0a108631||behlendorf1||Jan. 18, 2019, 7:14 p.m.||ztest: creates partially initialized root dataset
Since d8fdfc2 was integrated dsl_pool_create() does not call dmu_objset_create_impl() for the root dataset when running in userland (ztest): this creates a pool with a partially initialized root dataset. Trying to import and use this pool results in both zpool and zfs executables dumping core. Fix this by adopting an alternative change suggested in OpenZFS 8607 code review. Reviewed-by: Brian Behlendorf <firstname.lastname@example.org> Reviewed by: Tom Caputi <email@example.com> Original-patch-by: Robert Mustacchi <firstname.lastname@example.org> Signed-off-by: loli10K <email@example.com> Closes #8277cgit
|ad635071||noreply||Jan. 18, 2019, 7:11 p.m.||Remove zfs_sync() panicking kernel check
This check provides no real additional protection and unnecessarily introduces a dependency on the "oops_in_progress" kernel symbol. Remove the check, it there are special circumstances on other platforms which make this a requirement it can be reintroduced for all relevant call paths in a more portable comprehensive manor. Reviewed-by: Matt Ahrens <firstname.lastname@example.org> Reviewed-by: George Melikov <email@example.com> Signed-off-by: Brian Behlendorf <firstname.lastname@example.org> Closes #8297cgit
|b194fab0||behlendorf1||Jan. 18, 2019, 7:10 p.m.||Factor metaslab_load_wait() in metaslab_load()
Most callers that need to operate on a loaded metaslab, always call metaslab_load_wait() before loading the metaslab just in case someone else is already doing the work. Factoring metaslab_load_wait() within metaslab_load() makes the later more robust, as callers won't have to do the load-wait check explicitly every time they need to load a metaslab. Reviewed-by: Matt Ahrens <email@example.com> Reviewed-by: Brian Behlendorf <firstname.lastname@example.org> Signed-off-by: Serapheim Dimitropoulos <email@example.com> Closes #8290cgit
|960347d3||behlendorf1||Jan. 18, 2019, 7:06 p.m.||Fix 0 byte memory leak in zfs receive
Currently, when a DRR_OBJECT record is read into memory in receive_read_record(), memory is allocated for the bonus buffer. However, if the object doesn't have a bonus buffer the code will still "allocate" the zero bytes, but the memory will not be passed to the processing thread for cleanup later. This causes the spl kmem tracking code to report a leak. This patch simply changes the code so that it only allocates this memory if it has a non-zero length. Reviewed by: Matt Ahrens <firstname.lastname@example.org> Reviewed-by: Brian Behlendorf <email@example.com> Signed-off-by: Tom Caputi <firstname.lastname@example.org> Closes #8266cgit
|c0755420||emaste||Jan. 18, 2019, 6:22 p.m.||freebsd-update.8: mandoc -Tlint fixes|
|1a759200||behlendorf1||Jan. 18, 2019, 6:16 p.m.||Document guidelines for usage of zfs_dbgmsg
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by: Brian Behlendorf <email@example.com> Reviewed-by: Matt Ahrens <firstname.lastname@example.org> Reviewed-by: Igor Kozhukhov <email@example.com> Reviewed-by: George Melikov <firstname.lastname@example.org> Signed-off-by: Serapheim Dimitropoulos <email@example.com> Closes #8299cgit
|e45c1734||behlendorf1||Jan. 18, 2019, 6:10 p.m.||dkms: Enable debuginfo option to be set with zfs sysconfig file
On some Linux distributions, the kernel module build will not default to building with debuginfo symbols, which can make it difficult for debugging and testing. For this case, we provide a flag to override the build to force debuginfo to be produced for the kernel module build. Reviewed-by: Tony Hutter <firstname.lastname@example.org> Reviewed-by: Brian Behlendorf <email@example.com> Co-authored-by: Neal Gompa <firstname.lastname@example.org> Co-authored-by: Simon Watson <email@example.com> Signed-off-by: Neal Gompa <firstname.lastname@example.org> Signed-off-by: Simon Watson <email@example.com> Closes #8304cgit
|60b0a963||behlendorf1||Jan. 18, 2019, 5:58 p.m.||Off-by-one in zap_leaf_array_create()
Trying to set user properties with their length 1 byte shorter than the maximum size triggers an assertion failure in zap_leaf_array_create(): panic[cpu0]/thread=ffffff000a092c40: assertion failed: num_integers * integer_size < (8<<10) (0x2000 < 0x2000), file: ../../common/fs/zfs/zap_leaf.c, line: 233 ffffff000a092500 genunix:process_type+167c35 () ffffff000a0925a0 zfs:zap_leaf_array_create+1d2 () ffffff000a092650 zfs:zap_entry_create+1be () ffffff000a092720 zfs:fzap_update+ed () ffffff000a0927d0 zfs:zap_update+1a5 () ffffff000a0928d0 zfs:dsl_prop_set_sync_impl+5c6 () ffffff000a092970 zfs:dsl_props_set_sync_impl+fc () ffffff000a0929b0 zfs:dsl_props_set_sync+79 () ffffff000a0929f0 zfs:dsl_sync_task_sync+10a () ffffff000a092a80 zfs:dsl_pool_sync+3a3 () ffffff000a092b50 zfs:spa_sync+4e6 () ffffff000a092c20 zfs:txg_sync_thread+297 () ffffff000a092c30 unix:thread_start+8 () This patch simply corrects the assertion. Reviewed-by: Matt Ahrens <firstname.lastname@example.org> Reviewed-by: Brian Behlendorf <email@example.com> Signed-off-by: loli10K <firstname.lastname@example.org> Closes #8278cgit
|8dc2197b||behlendorf1||Jan. 18, 2019, 5:50 p.m.||Simplify spa_sync by breaking it up to smaller functions
The point of this refactoring is to break the high-level conceptual steps of spa_sync() to their own helper functions. In general large functions can enhance readability if structured well, but in this case the amount of conceptual steps taken could use the help of helper functions. Reviewed-by: Matt Ahrens <email@example.com> Reviewed-by: Brian Behlendorf <firstname.lastname@example.org> Signed-off-by: Serapheim Dimitropoulos <email@example.com> Closes #8293cgit
|ce5fb2a7||noreply||Jan. 18, 2019, 5:47 p.m.||ztest: scrub verification
By design ztest will never inject non-repairable damage in to the pool. Update the ztest_scrub() test case such that it waits for the scrub to complete and verifies the pool is always repairable. After enabling scrub verification two scenarios were encountered which are the result of how ztest manages failure injection. The first case is straight forward and pertains to detaching a mirror vdev. In this case, the pool must always be scrubbed prior the detach. Failure to do so can potentially lock in previously repairable data corruption by removing all good copies of a block leaving only damaged ones. The second is a little more subtle. The child/offset selection logic in ztest_fault_inject() depends on the calculated number of leaves always remaining constant between injection passes. This is true within a single execution of ztest, but when using zloop.sh random values are selected for each restart. Therefore, when ztest imports an existing pool it must be scrubbed before failure injection can be safely enabled. Otherwise it is possible that it will inject non-repairable damage. Reviewed by: Matt Ahrens <firstname.lastname@example.org> Reviewed by: Tom Caputi <email@example.com> Signed-off-by: Brian Behlendorf <firstname.lastname@example.org> Closes #8269cgit
|cfd9be9c||emaste||Jan. 18, 2019, 5:41 p.m.||freebsd-update: Use BASEDIR when checking for src component
src could potentially be installed under the based dir and not under the root or vice versa. PR: 224048 Submitted by: Gerald Aryeetey <aryeeteygerald_rogers.com> Reviewed by: delphij MFC after: 1 month Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D18849cgit ViewVC
|8f0916fc||kib||Jan. 18, 2019, 1:43 p.m.||i386/PAE busdma: allow more bounce pages.
If i386 has more than 4G of memory, allow the same number of busdma bounce pages as for amd64. In fact, in this case bouncing sometimes is much heavier than on amd64. Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential revision: https://reviews.freebsd.org/D18854cgit ViewVC
|957b9bbf||kib||Jan. 18, 2019, 1:38 p.m.||x86 busdma: fix mis-use of bus_addr_t where vm_paddr_t is assumed.
Right now bus_addr_t and vm_paddr_t are always aliased to the same underlying integer type on x86, which makes the interchange hard to detect. Shortly, i386 kernel would use uint64_t for vm_paddr_t to enable automatic use of PAE paging structures if hardware allows it, while bus_addr_t would be extended to 64bit only when PAE option is specified. Fix all places that were identified as using bus_addr_t while page address was assumed. This was performed by testing the complete PAE merging patch on machine with > 4G of RAM enabled. Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential revision: https://reviews.freebsd.org/D18854cgit ViewVC
|f2a496d6||kib||Jan. 18, 2019, 1:35 p.m.||MI VM: Make it possible to set size of superpage at boot instead of compile time.
In order to allow single kernel to use PAE pagetables on i386 if hardware supports it, and fall back to classic two-level paging structures if not, superpage code should be able to adopt to either 2M or 4M superpages size. There I make MI VM structures large enough to track the biggest possible superpage, by allowing architecture to define VM_NFREEORDER_MAX and VM_LEVEL_0_ORDER_MAX constants. Corresponding VM_NFREEORDER and VM_LEVEL_0_ORDER symbols can be defined as runtime values and must be less than the _MAX constants. If architecture does not define _MAXs, it is assumed that _MAX == normal constant. Reviewed by: markj Tested by: pho (as part of the larger patch) Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D18853cgit ViewVC
|6465f315||kib||Jan. 18, 2019, 10:54 a.m.||nvdimm: initialize SPA uuids statically.|