190c4c24 thj Aug. 2, 2022, 1:38 p.m.
This should make the output logic easier to read. No functional change

Sponsored by:	Klara, Inc.
c0e6ccb1 thj Aug. 2, 2022, 1:37 p.m.
This makes the output logic easier to read. No functional change

Sponsored by:	Klara, Inc.
264a559a thj Aug. 2, 2022, 1:36 p.m.
Remove redundant calculation for startmark.

Sponsored by:	Klara, Inc.
426afc8f melifaro Aug. 2, 2022, 1:24 p.m.
MFC after:	1 month
1abc27dd tuexen Aug. 2, 2022, 10:45 a.m.
While there, also fix the setting of the SYN related flag.

Reviewed by:		rrs
MFC after:		1 week
Sponsored by:		Netflix, Inc.
Differential Revision:	https://reviews.freebsd.org/D35862
93b8510c gbe Aug. 2, 2022, 6:33 a.m.
- ASCII is an acronym and there is no ascii(8) manual page
- Reference ascii(7) in the SEE ALSO section

Reported by:	karels
X-MFC with:	321dc6ee7e81
d1f5aa56 bz Aug. 1, 2022, 7:49 p.m.
Remove comments and change whitespace.
Cleanup the opt_* and -nclude opt_global.h bits to avoid various warnings.
fb1526ca bz Aug. 1, 2022, 7:40 p.m.
Originally, wtap_node_write() gets the wrong softc by iterating V_inet and
gets the ifp by string comparison, then gets softc by ifp->if_softc.
However, ifp->if_softc will not point to the correct softc owned by
ieee80211com, and thus causes a kernel panic.
Fix it by assigning softc to cdev's si_drv1 in wtap_vap_create()
and get the softc directly via dev->si_drv1 in wtap_node_write().

The cdev created by wtap_vap_create() use the name of ieee80211com
rather than the vap's name. It will cause the second vap based on
the same ieee80211com as first vap fail to create a device node
because the device node is already exists. Fix it by assigning
vap->iv_ifp->if_xname to cdev's name.

Sponsored by:	Google, Inc. (GSoC 2022)
Reviewed by:	adrian, cy, bz
Differential Revision: https://reviews.freebsd.org/D35752
2c4276aa thj Aug. 1, 2022, 1:54 p.m.
This makes the code easier to follow, no functional changes intended

Sponsored by:	Klara, Inc.
ca53a844 thj Aug. 1, 2022, 1:53 p.m.
Sponsored by:	Klara, Inc.
85d92faf thj Aug. 1, 2022, 1:14 p.m.
Sponsored by:	Klara, Inc.
9f35dbfd hselasky Aug. 1, 2022, 11:26 a.m.
PR:		265514
MFC after:	1 week
Sponsored by:	NVIDIA Networking
ae6bfd12 melifaro Aug. 1, 2022, 10:02 a.m.
* Make nhgrp_get_nhops() return const struct weightened_nhop to
 indicate that the list is immutable
* Make nhgrp_get_group() return the actual group, instead of

MFC after:	2 weeks
f28532a0 melifaro Aug. 1, 2022, 9:20 a.m.
The test was failing due to the assert on lack of MSG_TRUNC flag in the
 output flags of recvmsg().
The code passed MSG_TRUNC, along with sufficient-size buffer to hold the
 message to-be-received to the recvmsg(), and expected MSG_TRUNC to be
 returned as well.

This is not exactly correct as a) MSG_TRUNC was not even a supported
 recvmsg() flag before be1f485d7d6b and b) it violates POSIX, as
 POSIX states it should be set only "If a message is too long to fit in
 the supplied buffers,".
The test was working before as the kernel copied input flags to the
 output flags. be1f485d7d6b changed that behaviour to clear MSG_TRUNC
 if it was present on the input.

Fix the test by checking POSIX-defined behaviour.

Discussed with:	glebius
5c23343b melifaro Aug. 1, 2022, 8:55 a.m.
Convert the last remaining pieces of old-style debug messages
 to the new debugging framework.

Differential Revision: https://reviews.freebsd.org/D35994
MFC after:	2 weeks