ded0d3d4 se Oct. 4, 2021, 8:10 p.m.
d6c323ed se Oct. 4, 2021, 8:10 p.m.
These files will be added back in updated form, but are only relevant
for the Windows platform, anyway.
d18c9a91 dab Oct. 4, 2021, 5:45 p.m.
RPCINFO on macOS behaves different compared to other linux clients and
doesn't provide request address in rpcb structure of the
RPCBPROC_GETADDRLIST call which doesn't seem to be forbidden.

In this case RPCBIND uses RPC call's source address and picks a
closest corresponding local address. If there are no addresses in the
same subnet as the source address, return of RPCBIND may vary
depending on the order of addresses returned in getifaddrs. If a link
local precedes global address it may be returned even if the request
comes from neither a link local nor from link local in a different
scope, which will prevent services like nfs from working in tpc6
scenario on macOS clients. Issue can be seen only on FreeBSD rpcbind
port due to changes in workflow of addrmerge call.

Submitted by:	Dmitry Ovsyannikov (
Reviewers:	dab
Differential Revision:
Sponsored by:	Dell EMC
MFC to:	stable/12, stable/13
MFC after:	1 week
d6dffbae imp Oct. 4, 2021, 4:51 p.m.
These tests will run only on a sparc64 system, and so never run anymore.

Sponsored by:		Netflix
69f7649b markj Oct. 4, 2021, 4:28 p.m.
PR:		258763
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
105fd928 markj Oct. 4, 2021, 4:28 p.m.
When copying a struct or union from one CTF container to another,
ctf_add_type() checks whether it matches an existing type in the
destination container.  It does so by looking for a type with the same
name and kind as the new type, and if one exists, it iterates over all
members of the source type and checks whether a member with matching
name and offset exists in the matched destination type.  This can
produce false positives, for example because member types are not
compared, but this is not expected to arise in practice.  If the match
fails, ctf_add_type() returns an error.

The procedure used for member comparison breaks down in the face of
anonymous struct and union members.  ctf_member_iter() visits each
member in the source definition and looks up the corresponding member in
the desination definition by name using ctf_member_info(), but this
function will descend into anonymous members and thus fail to match.
Fix the problem by introducing a custom comparison routine which does
not assume member names are unique.  This should also be faster for
types with many members; in the previous scheme, membcmp() would perform
a linear scan of the desination type's members to perform a lookup by
name.  The new routine steps through the members of both types in a
single loop.

PR:		258763
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
507a22be andrew Oct. 4, 2021, 12:21 p.m.
Sponsored by:	The FreeBSD Foundation
cc46927f bapt Oct. 4, 2021, 12:16 p.m.
27803b54 bapt Oct. 4, 2021, 10:31 a.m.
after the split, curses.h is now generated by tinfo Makefile, but
still used for a file generated in ncurses lib. Adjust the path to
make sure curses.h is always found
16f1ee11 bapt Oct. 4, 2021, 9:38 a.m.
19deec3b bapt Oct. 4, 2021, 9:38 a.m.
both distextract and distfetch does not directly use ncurses,
or figpart, drop their direct link to those libs
cbc83e37 bapt Oct. 4, 2021, 9:38 a.m.
396851c2 bapt Oct. 4, 2021, 9:38 a.m.
many external program expects libncurses to not be provided as a single
library. Instead of fixing all ports, distribute ncurses the way
upstream distributes it

Turn into a ldscript which will link automatically as
needed to libtinfow so so this change is seamless at compile time.

Differential Revision:
8bc5971b hselasky Oct. 4, 2021, 9:01 a.m.
Differential Revision:
Sponsored by:	NVIDIA Networking
f774652b se Oct. 4, 2021, 7:50 a.m.
The tests that come with version 5.0.2 have been extended to cover the
line editing functions. It has been found that these tests generate
false negative results in FreeBSD, most likely due to an issue in the
pexpect functionality used.

These history tests are skipped on systems that do not have python and
py-pexpect installed (and thus are unlikely to cause CI test failures),
but in order to not cause irritating failures on systems were these
packages are in fact installed, I temporarily disconnect them.

I had planned to skip this version due to the issue with the history
tests, but some committer has asked me to go ahead since the currently
used version 5.0.0 contains a macro name that collides with a project
he is working on.

No MFC of this version is planned. A version 5.0.3 is expected to be
released soon, and that version will allow to reconnect the tests and
will be MFCed.