46eab860 markj July 17, 2022, 5:58 p.m.
- Use LIST_FOREACH_SAFE.
- Simplify control flow.

No functional change intended.

MFC after:	1 week
Sponsored by:	The FreeBSD Foundation
cgit
aac7c7ac markj July 17, 2022, 5:58 p.m.
The passed cpuid is always equal to the one stored in the callout
structure.  No functional change intended.

MFC after:	1 week
Sponsored by:	The FreeBSD Foundation
cgit
fb0493d5 dim July 17, 2022, 5:57 p.m.
Clang 15 warns:

    sys/dev/cxgbe/cudbg/cudbg_lib.c:2949:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
            int i = 0;
                ^

Apparently 'i' was meant as the current retry counter, but '1' was used
in the while loop comparison instead, making the loop potentially
infinite, if 'busy' never gets reset.

MFC after:	3 days
Reviewed by:	np
Differential Revision: https://reviews.freebsd.org/D35834
cgit
752b6dae cy July 17, 2022, 2:25 p.m.
The last number of unbound upgrades failed to manually update the
version strings in usr.sbin/unbound/config.h. This commit fixes that.

Reported by:	"Herbert J. Skuhra" <herbert@gojira.at>
Fixes:		0a92a9fca737edafbad03ee5a8efebe302851cff
		a39a5a6905612447def27b66ffe73b9d11efd80c
		9cf5bc93f6ba1711ae7bf96a982a2b3c8b073a18
		273016e836aa378789612e0a0e08d50f28be778e
		24e365220007c415f495cf8dcb228ece6002b8b7
		5469a9953005a9a4d4aad7be88545d441622e9a0
MFC after:	3 days
cgit
a5f59e85 emaste July 17, 2022, 12:14 p.m.
Sponsored by:	The FreeBSD Foundation
cgit
7f3c78fb markj July 17, 2022, 11:09 a.m.
Keep the definition around since it's used by userspace.

Reviewed by:	alc, imp, kib
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D35791
cgit
1424f65b markj July 17, 2022, 11:09 a.m.
It's unused now.  Keep the OBJ_DEFAULT identifier, but make it an alias
of OBJT_SWAP for the benefit of out-of-tree code.

Reviewed by:	alc, imp, kib
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D35790
cgit
fff19e0e markj July 17, 2022, 11:09 a.m.
With the removal of OBJT_DEFAULT, OBJ_ANON implies OBJ_SWAP.

Note, this means that vm_object_split() is more expensive than it used
to be, as it holds busy locks until the end of the range is reached,
even if the object has no swap blocks allocated.

Reviewed by:	alc, kib
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D35789
cgit
0cb2610e markj July 17, 2022, 11:09 a.m.
Now that OBJT_DEFAULT objects can't be instantiated, we can simplify
checks of the form object->type == OBJT_DEFAULT || (object->flags &
OBJ_SWAP) != 0.  No functional change intended.

Reviewed by:	alc, kib
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D35788
cgit
fffc1c59 markj July 17, 2022, 11:09 a.m.
With the removal of OBJT_DEFAULT, we can simply handle this in
swap_pager_dealloc().  No functional change intended.

Suggested by:	alc
Reviewed by:	alc, kib
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D35787
cgit
cb6757c0 markj July 17, 2022, 11:09 a.m.
With the removal of OBJT_DEFAULT, we can assume that pager operations
provide an object with OBJ_SWAP set.  Also, we do not need to convert
objects from type OBJT_DEFAULT.  Thus, remove checks for OBJ_SWAP and
remove code which modifies the object type.  In some places, replace the
check for OBJ_SWAP with a check for whether any swap blocks are
assigned.

Reviewed by:	alc, kib
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D35786
cgit
5d32157d markj July 17, 2022, 11:09 a.m.
With this change, OBJT_DEFAULT objects are no longer allocated.
Instead, anonymous objects are always of type OBJT_SWAP and always have
OBJ_SWAP set.

Modify the page fault handler to check the swap block radix tree in
places where it checked for objects of type OBJT_DEFAULT.  In
particular, there's no need to invoke getpages for an OBJT_SWAP object
with no swap blocks assigned.

Reviewed by:	alc, kib
Tested by:	pho
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D35785
cgit
6226f8f2 pho July 17, 2022, 7:16 a.m.
da55f86c alc July 16, 2022, 11:05 p.m.
Reviewed by:	kib
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D35832
cgit
cab04003 dim July 16, 2022, 7:13 p.m.
Clang 15 warns:

    sys/dev/cxgb/cxgb_sge.c:1290:21: error: variable 'txsd' set but not used [-Werror,-Wunused-but-set-variable]
            struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx];
                               ^

It appears 'txsd' is a leftover from a previous refactoring (see
3f345a5d09b6), but is no longer used for anything, and can be removed
without any functional change.

MFC after:	3 days
Reviewed by:	np
Differential Revision: https://reviews.freebsd.org/D35833
cgit