a9fd00a8 wosch Feb. 5, 2022, 6:30 p.m.
a0e33bbd wosch Feb. 5, 2022, 5:35 p.m.
179a53bb wosch Feb. 5, 2022, 5:14 p.m.
83e66677 wosch Feb. 5, 2022, 5:11 p.m.
c918f50f wosch Feb. 5, 2022, 5:09 p.m.
1790549d rscheff Feb. 5, 2022, 3:55 p.m.
Incorrectly used KMOD_ marco in static kernel ECN functions.

Both eventually resolve to counter_s64_add(), but better
use the correct macros.

Reviewed By: tuexen, #transport
Sponsored by:        NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D34181
fc035df8 afedorov Feb. 5, 2022, 3:47 p.m.
PR:	254343, 255054
Reviewed by:	vmaffione (mentor), donner
Approved by:	vmaffione (mentor), donner
MFC after:	2 weeks
Sponsored by:	vstack.com
Differential Revision:	https://reviews.freebsd.org/D30639
f7220c48 rscheff Feb. 5, 2022, 2:04 p.m.
Reduce the burden to maintain correct and
extensible ECN related code across multiple
stacks and codepaths.

Formally no functional change.

Incidentially this establishes correct
ECN operation in one instance.

Reviewed By: rrs, #transport
Sponsored by:        NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D34162
9535d9f1 se Feb. 5, 2022, 12:33 p.m.
Testing had revealed that trying to retrieve the user.localbase
variable into to small a buffer would return the correct error code,
but would not fill the available buffer space with a partial result.

A partial result is of no use, but this is still a violation of the
documented behavior, which has been fixed in the previous commit to
this function.

I just checked the code for "user.cs_path" and found that it had the
same issue.

Instead of fixing the logic for each user.* sysctl string variable
individually, this commit adds a helper function set_user_str() that
implements the semantics specified in the sysctl() man page.

It is currently only used for "user.cs_path" and "user.localbase",
but it will offer a significant simplification when further such
variables will be added (as I intend to do).

MFC after:	3 days
34478b73 kp Feb. 5, 2022, 9:31 a.m.
The pf tests have the ability to log state information (pf rules, pf
states, interfaces, ...) on exit (i.e. on success or on error).
This is useful, but only in specific cases. When it's not needed it may
get in the way of clear output.

Test scripts can add 'debug' to the pft_init call to enable this for the
specified test.

Reviewed by:	brd
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D34133
10941899 kp Feb. 5, 2022, 9:29 a.m.
MFC after:	2 weeks
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D34132
b21826bf kp Feb. 5, 2022, 9:29 a.m.
When we create a table without counters, add an entry  and later
re-define the table to have counters we wound up trying to read
non-existent counters.

We now cope with this by attempting to add them if needed, removing them
when they're no longer needed and not trying to read from counters that
are not present.

MFC after:	2 weeks
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D34131
610b97eb wosch Feb. 5, 2022, 9:13 a.m.
153dd4ba wosch Feb. 5, 2022, 9:08 a.m.
1c7a40d2 wosch Feb. 5, 2022, 9 a.m.