committer filter by committer.
@path/to/ filter by path in repository.
committer@path/to/ filter by committer AND path in repository.
abdef0123 filter by commit's SHA hash.
rNNN filter by SVN revision.
rNNN-rMMM filter by SVN revisions range (inclusive).
Multiple filters can be specified separated by spaces or comas in which case they'll be combined using OR operator.
a3238e92 | imp | June 11, 2021, 4:54 p.m. | style: Relax 80 column rule
Note that the 80 column rule has been relaxed for some time when things are clearer when a little longer. Add in that things that people grep for, such as error messages, shouldn't be broken up which is the most common reason people exceed 80 columns intentionally. Reviewed by: jhb, domagoj.stolfa@gmail.com Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D30255cgit |
|
ab6145c9 | imp | June 11, 2021, 4:54 p.m. | style: tweak tab after #define advice
Once upon a time, #define<tab> was cultural thing. However, even when it was promulgated, it was a minority usage. 20 years ago the split was 30k/69k (tab/space) and today the split is 80k/546k (tab/space). Update guidance to allow either with the usual suggestion to be consistent within a file. Reviewed by: sef, allenjude, 0mp (prior rev), jhb Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D30254cgit |
|
10bcc4da | behlendorf1 | June 11, 2021, 4:10 p.m. | scripts/commitcheck.sh: fix false positive for signed commits
Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12105cgit |
|
feb04e66 | behlendorf1 | June 11, 2021, 4:10 p.m. | Forbid basename(3) and dirname(3)
There are at least two interpretations of basename(3), in addition to both functions being allowed to /both/ return a static buffer (unsuitable in multi-threaded environments) /and/ raze the input (which encourages overallocations, at best) Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12105cgit |
|
64dfdaba | behlendorf1 | June 11, 2021, 4:10 p.m. | libzutil: import: filter out unsuitable files earlier
Only accept the right type of file, if available, and reject too-small files before opening them on Linux Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12105cgit |
|
bf80fb53 | behlendorf1 | June 11, 2021, 4:10 p.m. | linux/libzutil: zpool_open_func: don't dup name, extract untouchables
Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12105cgit |
|
0854d4c1 | behlendorf1 | June 11, 2021, 4:10 p.m. | libzutil: add zfs_{base,dir}name()
Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12105cgit |
|
3aa81a66 | behlendorf1 | June 11, 2021, 4:10 p.m. | linux/libzutil: use ARRAY_SIZE instead of constant for search paths
Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #12105cgit |
|
89d5cbb8 | oshogbo | June 11, 2021, 3:51 p.m. | libnv: optimize nvlist size calculation
If we had a multiple nvlist, during nvlist_pack, we calculated the size of every nvlist separately. For example, if we had a nvlist with three nodes each containing another (A contains B, and B contains C), we first calculated the size of nvlist A (which contains B, C), then we calculate the size of B (which contains C, notice that we already did the calculation of B, when we calculate A), and finally C. This means that this calculation was O(N!). This was done because each time we pack nvlist, we have to put its size in the header (the separate header for A, B, and C). To not break the ABI and to reduce the complexity of nvlist_size, instead of calculating the nvlist size when requested, we track the size of each nvlist. Reported by: pjd, kp Tested by: kpcgit |
|
1a345d64 | noreply | June 11, 2021, 3:38 p.m. | Added uncompress requirement
Having an old enough version of "file" and no "uncompress" program installed can cause rpmbuild as root to crash and mangle rpmdb. So let's add a build dependency for RPM-based systems. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes: #12071 Closes: #12168cgit |
|
ba1b3e48 | rrs | June 11, 2021, 3:38 p.m. | tcp: Missing mfree in rack and bbr
Recently (Nov) we added logic that protects against a peer negotiating a timestamp, and then not including a timestamp. This involved in the input path doing a goto done_with_input label. Now I suspect the code was cribbed from one in Rack that has to do with the SYN. This had a bug, i.e. it should have a m_freem(m) before going to the label (bbr had this missing m_freem() but rack did not). This then caused the missing m_freem to show up in both BBR and Rack. Also looking at the code referencing m->m_pkthdr.lro_nsegs later (after processing) is not a good idea, even though its only for logging. Best to copy that off before any frees can take place. Reviewed by: mtuexen Sponsored by: Netflix Inc Differential Revision: https://reviews.freebsd.org/D30727cgit |
|
9d639d87 | noreply | June 11, 2021, 3:21 p.m. | ZTS: Add zfs_clone_livelist_dedup.ksh to Makefile.am
Commit 86b5f4c12 added a new zfs_clone_livelist_dedup.ksh test case but didn't include it in the Makefile.am. This results in the test not being included in the dist tarball so it's never run by the CI. Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes: #12224cgit |
|
6847ea50 | hselasky | June 11, 2021, 3:06 p.m. | Improve handling of USB device re-open in the LibUSB v1.x API.
Make sure the "device_is_gone" flag is cleared after every successful open, so that the "device_is_gone" flag doesn't persist forever. Found by: sergii.dmytruk@3mdeb.com PR: 256296 MFC after: 1 week Sponsored by: Mellanox Technologies // NVIDIA Networkingcgit |
|
fa3746be | tuexen | June 11, 2021, 1:40 p.m. | tcp: fix two bugs in new reno
* Completely initialise the CC module specific data * Use beta_ecn in case of an ECN event whenever ABE is enabled or it is requested by the stack. Reviewed by: rscheff, rrs MFC after: 3 days Sponsored by: Netflix, Inc.cgit |
|
a7cf31da | hselasky | June 11, 2021, 11:05 a.m. | Add new USB ID to u3g(4).
Submitted by: pierre-jean.gineste@nuabee.fr PR: 231909 MFC after: 1 week Sponsored by: Mellanox Technologies // NVIDIA Networkingcgit |