r363177 br July 14, 2020, 10:55 a.m.
so it can be used on other IOMMU systems.

Provide MI iommu_unit, iommu_domain and iommu_ctx structs in sys/iommu.h;
use them as a first member of MD dmar_unit, dmar_domain and dmar_ctx.

Change the namespace in DMAR backend: use iommu_ prefix instead of dmar_.

Move some macroses and function prototypes to sys/iommu.h.

Reviewed by:	kib
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D25574
r363176 adrian July 14, 2020, 5:33 a.m.
pointed out by gonzo@, thanks!
r363174 adrian July 14, 2020, 5:10 a.m.
I noticed when compiling with ye olde gcc-6.3.0 on mips that it tripped over
a lack of C++11 bits.  This allows it to compile fine.
r363173 adrian July 14, 2020, 5:07 a.m.
This is mostly an exercise to set variables to NULL/0 when declared, but
one was ensuring a string variable was set before printing it.
We should never see "<unknown>" in a printed rule; if we do then this code
definitely has some bugs that need addressing.
r363172 adrian July 14, 2020, 5:02 a.m.
I guess this didn't like the case statements.. ? But this does quieten
the compiler error.
r363171 adrian July 14, 2020, 5 a.m.
This was triggering a pointer-losing-constness error.
r363170 jkim July 14, 2020, 1:54 a.m.
Update byacc to 20200330.
r363169 allanjude July 14, 2020, 12:46 a.m.
Submitted by:	Rob Fairbanks <rob.fx907@gmail.com>
Reported by:	Michael Butler <imb@protected-networks.net>
MFC with:	r363110
Sponsored by:	Klara Inc.
r363167 np July 13, 2020, 7:15 p.m.
to coalesce tx work requests.

Note that Coverity will still treat this as an out-of-bounds access.  We
do want to compare 16B starting from ethmacdst but cmp_l2hdr was was
going beyond that by 2B.

cmp_l2hdr was introduced in r362905.

Reported by:	Coverity (CID 1430284)
Sponsored by:	Chelsio Communications
r363166 markj July 13, 2020, 7:10 p.m.
struct _ipfw_dyn_rule is defined as packed, and as a result, its
uint64_t fields are misaligned on some 32-bit platforms.  Since
pr_u64() is explicitly supposed to handle this case, avoid using a
uint64_t * for the input pointer to make sure that the compiler won't
(correctly) warn about the misalignment.

Reported by:	jenkins
MFC with:	r363164
r363165 lwhsu July 13, 2020, 6:19 p.m.
This is supposed to be fixed by r363068

PR:		240049
Sponsored by:	The FreeBSD Foundation
r363164 markj July 13, 2020, 5:51 p.m.
- Add missing const and static qualifiers.
- Avoid shadowing the global "co" by renaming it to "g_co".
- Avoid mixing signedness in loop bound checks.
- Leave -Wcast-align warnings disabled for now.

Reviewed by:	ae, melifaro
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D25456
r363162 markj July 13, 2020, 5:05 p.m.
PR:		243682
Reviewed by:	andrew, emaste
MFC after:	1 week
Event:		July 2020 Bugathon
Differential Revision:	https://reviews.freebsd.org/D25625
r363158 markj July 13, 2020, 4:39 p.m.
This is required for standalone module builds.

Reported by:	hselasky
Reviewed by:	dougm, hselasky, kib
MFC after:	3 days
Differential Revision:	https://reviews.freebsd.org/D25650
r363157 mav July 13, 2020, 4:23 p.m.
MFC after:	2 weeks